bug-gnu-utils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: minor gettext nits


From: Bruno Haible
Subject: Re: minor gettext nits
Date: Sun, 14 Sep 2008 14:49:33 +0200
User-agent: KMail/1.5.4

Hi Ralf,

> gettext-tools/ChangeLog:
> 2008-09-14  Ralf Wildenhues  <address@hidden>
> 
>       * configure.ac: Use AC_TYPE_UNSIGNED_LONG_LONG_INT instead of
>       gl_AC_TYPE_UNSIGNED_LONG_LONG.

Thanks, applied. I didn't notice this because I had an old copy of
ulonglong.m4 sitting around in my workspace.

> gettext-tools/src/ChangeLog:
> 2008-09-14  Ralf Wildenhues  <address@hidden>
> 
>       * xgettext.c: Include concat-filename.h, for
>       concatenated_filename.

Oops, a left-over from a change two weeks ago. Thanks, completed and applied.

> gnulib-local/ChangeLog:
> 2008-09-14  Ralf Wildenhues  <address@hidden>
> 
>       * modules/libglib: For all generated headers, depend on
>       glib/$(am__dirstamp) rather than calling mkdir, to be safe for
>       parallel make.
>       * modules/libxml: Likewise, with libxml/$(am__dirstamp).
> ...
> The am__dirstamp is to avoid parallel build failure.
> It relies on an undocumented automake macro name.
> If that disturbs you, then we can either document it,
> or use another rule that invokes $(mkdir_p) rather than
> plain mkdir.  That's still efficient, and parallel-safe.

Indeed I prefer to not use undocumented symbols from automake. I think this
level of detail is beyond what automake should document: $(am__dirstamp) is
an artifact of the _current_ output generated by automake and could change
in future versions. Also, automake documents one way to reliably create
directories; it does not need a second one. I'm applying this.

Bruno


2008-09-14  Bruno Haible  <address@hidden>

        * modules/libxml: Use $(mkdir_p) to create the libxml directory.
        * modules/libglib: Use $(mkdir_p) to create the glib directory.
        Suggested by Ralf Wildenhues <address@hidden>.

--- modules/libxml      26 Oct 2007 09:32:36 -0000      1.8
+++ modules/libxml      14 Sep 2008 12:44:13 -0000
@@ -164,329 +164,329 @@
 BUILT_SOURCES += $(LIBXML_H)
 
 libxml/DOCBparser.h: libxml/DOCBparser.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/DOCBparser.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/HTMLparser.h: libxml/HTMLparser.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/HTMLparser.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/HTMLtree.h: libxml/HTMLtree.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/HTMLtree.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/SAX.h: libxml/SAX.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/SAX.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/SAX2.h: libxml/SAX2.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/SAX2.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/c14n.h: libxml/c14n.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/c14n.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/catalog.h: libxml/catalog.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/catalog.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/chvalid.h: libxml/chvalid.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/chvalid.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/debugXML.h: libxml/debugXML.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/debugXML.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/dict.h: libxml/dict.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/dict.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/encoding.h: libxml/encoding.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/encoding.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/entities.h: libxml/entities.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/entities.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/globals.h: libxml/globals.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/globals.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/hash.h: libxml/hash.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/hash.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/list.h: libxml/list.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/list.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/nanoftp.h: libxml/nanoftp.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/nanoftp.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/nanohttp.h: libxml/nanohttp.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/nanohttp.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/parser.h: libxml/parser.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/parser.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/parserInternals.h: libxml/parserInternals.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/parserInternals.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/pattern.h: libxml/pattern.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/pattern.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/relaxng.h: libxml/relaxng.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/relaxng.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/schemasInternals.h: libxml/schemasInternals.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/schemasInternals.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/schematron.h: libxml/schematron.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/schematron.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/threads.h: libxml/threads.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/threads.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/tree.h: libxml/tree.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/tree.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/uri.h: libxml/uri.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/uri.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/valid.h: libxml/valid.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/valid.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/xinclude.h: libxml/xinclude.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/xinclude.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/xlink.h: libxml/xlink.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/xlink.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/xmlIO.h: libxml/xmlIO.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/xmlIO.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/xmlautomata.h: libxml/xmlautomata.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/xmlautomata.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/xmlerror.h: libxml/xmlerror.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/xmlerror.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/xmlexports.h: libxml/xmlexports.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/xmlexports.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/xmlmemory.h: libxml/xmlmemory.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/xmlmemory.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/xmlmodule.h: libxml/xmlmodule.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/xmlmodule.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/xmlreader.h: libxml/xmlreader.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/xmlreader.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/xmlregexp.h: libxml/xmlregexp.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/xmlregexp.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/xmlsave.h: libxml/xmlsave.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/xmlsave.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/xmlschemas.h: libxml/xmlschemas.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/xmlschemas.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/xmlschemastypes.h: libxml/xmlschemastypes.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/xmlschemastypes.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/xmlstring.h: libxml/xmlstring.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/xmlstring.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/xmlunicode.h: libxml/xmlunicode.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/xmlunicode.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/xmlversion.h: libxml/xmlversion.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/xmlversion.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/xmlwriter.h: libxml/xmlwriter.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/xmlwriter.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/xpath.h: libxml/xpath.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/xpath.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/xpathInternals.h: libxml/xpathInternals.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/xpathInternals.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 libxml/xpointer.h: libxml/xpointer.in.h
-       test -d libxml || mkdir libxml
+       test -d libxml || $(mkdir_p) libxml
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/libxml/xpointer.in.h; \
        } > address@hidden
--- modules/libglib     14 Sep 2008 10:25:06 -0000      1.5
+++ modules/libglib     14 Sep 2008 12:44:13 -0000
@@ -59,42 +59,42 @@
        mv -f address@hidden $@
 
 glib/ghash.h: glib/ghash.in.h
-       test -d glib || mkdir glib
+       test -d glib || $(mkdir_p) glib
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/glib/ghash.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 glib/glist.h: glib/glist.in.h
-       test -d glib || mkdir glib
+       test -d glib || $(mkdir_p) glib
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/glib/glist.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 glib/gprimes.h: glib/gprimes.in.h
-       test -d glib || mkdir glib
+       test -d glib || $(mkdir_p) glib
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/glib/gprimes.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 glib/gstrfuncs.h: glib/gstrfuncs.in.h
-       test -d glib || mkdir glib
+       test -d glib || $(mkdir_p) glib
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/glib/gstrfuncs.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 glib/gstring.h: glib/gstring.in.h
-       test -d glib || mkdir glib
+       test -d glib || $(mkdir_p) glib
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/glib/gstring.in.h; \
        } > address@hidden
        mv -f address@hidden $@
 
 glib/gtypes.h: glib/gtypes.in.h
-       test -d glib || mkdir glib
+       test -d glib || $(mkdir_p) glib
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
          cat $(srcdir)/glib/gtypes.in.h; \
        } > address@hidden





reply via email to

[Prev in Thread] Current Thread [Next in Thread]