Re: sharutils 4.8 has been released

[Eric Blake]

According to Bruce Korb on 2/19/2010 2:39 PM:
> 
> Primary focus:  version 3 of GPL
> Secondary: minor bug fixes & gnulib-ification
> 
> Download:  http://ftp.gnu.org/gnu/sharutils/sharutils-4.8.tar.gz

This package is broken on non-glibc machines, because it tries to use the
non-existent gnu_basename (provided by a macro in basename.h).

gcc-4  -O2 -pipe    -o unshar.exe unshar.o encode.o   ../lib/libgnu.a
-lintl ../lib/libgnu.a
unshar.o:unshar.c:(.text+0x836): undefined reference to `_gnu_basename'

This is the patch I applied as a stop-gap for cygwin (even though leaks
memory on calls to basename()).  But you may want to further re-visit how
version strings are printed, by instead using the gnulib module
version-etc-fsf for the bulk of the locations that call basename(), and by
fixing walktree() in shar.c to blindly call base_name() then free() the
result at the right point.  Or you might check if last_component() (also
part of the dirname module) is better for your needs than base_name().

Alas, I haven't managed to bootstrap sharutils from CVS, since it depends
on autogen, but autogen is not yet properly ported to cygwin.

-- 
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden

sharutils-4.8-1.src.patch
Description: Source code patch

signature.asc
Description: OpenPGP digital signature