Re: [sharutils-4.11.1] Compilation warnings

[Petr Pisar]

On Wed, Dec 05, 2012 at 09:28:01AM -0800, Bruce Korb wrote:
> 
> Meanwhile, in the intervening 18 months, there have been a few changes
> that obliterated the unused variable.  I've now fixed the aliasing
> issue, but I've not audited sharutils for full aliasing compliance.
> Please give the pending release a spin:
> 
> http://autogen.sourceforge.net/data/sharutils-4.12.2.tar.bz2
> 
Great. It compiles and all tests pass on various architectures (i686, amd64,
PPC, PPC64, S390, S390x). The original warnings have been resolved.

However a few new ones appeared in the bundled libopts code:

make[2]: Entering directory `/builddir/build/BUILD/sharutils-4.12.2/libopts'
gcc -DHAVE_CONFIG_H -I. -I..  -I.  -Wno-format-contains-nul -O2 -g -pipe -Wall 
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector 
--param=ssp-buffer-size=4  -m32 -Wno-format-contains-nul -c -o 
libopts_a-libopts.o `test -f 'libopts.c' || echo './'`libopts.c
In file included from libopts.c:28:0:
genshell.c: In function 'AO_gettext':
genshell.c:387:9: warning: implicit declaration of function 'dgettext' 
[-Wimplicit-function-declaration]
genshell.c:387:15: warning: incompatible implicit declaration of built-in 
function 'dgettext' [enabled by default]
genshell.c:389:17: warning: assignment discards 'const' qualifier from pointer 
target type [enabled by default]
genshell.c:391:13: warning: assignment discards 'const' qualifier from pointer 
target type [enabled by default]
In file included from libopts.c:33:0:
pgusage.c: In function 'optionPagedUsage':
pgusage.c:67:9: warning: format '%lu' expects argument of type 'long unsigned 
int', but argument 4 has type 'long long unsigned int' [-Wformat]
pgusage.c:67:9: warning: format '%lu' expects argument of type 'long unsigned 
int', but argument 4 has type 'long long unsigned int' [-Wformat]
pgusage.c:108:18: warning: format '%lu' expects argument of type 'long unsigned 
int', but argument 5 has type 'long long unsigned int' [-Wformat]
pgusage.c:108:18: warning: format '%lu' expects argument of type 'long unsigned 
int', but argument 5 has type 'long long unsigned int' [-Wformat]
pgusage.c:108:18: warning: format '%lu' expects argument of type 'long unsigned 
int', but argument 5 has type 'long long unsigned int' [-Wformat]
pgusage.c:108:18: warning: format '%lu' expects argument of type 'long unsigned 
int', but argument 5 has type 'long long unsigned int' [-Wformat]
pgusage.c:112:9: warning: ignoring return value of 'system', declared with 
attribute warn_unused_result [-Wunused-result]

And in shar.c:

shar.c: In function 'configure_shar':
shar.c:1969:13: warning: ignoring return value of 'freopen', declared with 
attribute warn_unused_result [-Wunused-result]

The genshell.c and shar.c warnings exhibit everywhere, the psuage.c on 32-bit
user space only.

-- Petr

pgpVZvJX9por1.pgp
Description: PGP signature