[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [sharutils] find_archive() passes off_t to fseek()
|
From: |
Petr Pisar |
|
Subject: |
Re: [sharutils] find_archive() passes off_t to fseek() |
|
Date: |
Mon, 2 Dec 2013 08:35:02 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Dec 02, 2013 at 08:27:01AM +0100, Petr Pisar wrote:
> Hello,
>
> current (4.14) src/unshar.c:find_archive() has third argument of type off_t,
> and passed the value to fseek(3) function which expects long. Standard library
> offers fseeko(3) for this reason.
>
> I propose replace fseek() call with fseeko().
>
Similar bug is at ftell() calls which returns long, but you assign the value
into off_t. There is ftello() again.
-- Petr
pgpgkygHqpPeT.pgp
Description: PGP signature