bug-gnubg
[Top][All Lists]

## Re: [Bug-gnubg] Two patch sets - one for Joseph Heled

 From: Joseph Heled Subject: Re: [Bug-gnubg] Two patch sets - one for Joseph Heled Date: Tue, 12 Nov 2002 07:36:31 +1300 User-agent: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.1) Gecko/20020829

Personally, I would not make a UI setting for the move filter. I can't see any user changing this, and I am not sure we want her to. We may have some reasonable 'Sets' which can be chosen in the GUI - default, wide, etc.
```
-Joseph

Jim Segrave wrote:
```
```On Mon 11 Nov 2002 (13:52 +0100), ?ystein O Johansen wrote:

```
```Those of you who want to try this patch for windows, I have a binary here:
http://home.online.no/gnubg-getmemultiple.exe

Jim? This is probably just a local problem at my machine...
I can't get the prune filter patch to work....
C:\gnubg-gtk13\gnubg>patch -p0 < movefilter.diff
patching file analysis.c
patching file backgammon.h
patching file eval.c
Hunk #1 succeeded at 340 (offset 1 line).
Hunk #2 FAILED at 5703.
Hunk #3 FAILED at 5735.
Hunk #4 FAILED at 5754.
Hunk #5 FAILED at 5782.
Hunk #6 FAILED at 5811.
Hunk #7 FAILED at 5843.
Hunk #8 FAILED at 5864.
Hunk #9 FAILED at 5890.
Hunk #10 FAILED at 5920.
Hunk #11 FAILED at 5952.
Hunk #12 FAILED at 5968.
Hunk #13 FAILED at 6005.
Hunk #14 succeeded at 6096 with fuzz 2 (offset 75 lines).
patch: **** Can't rename file eval.c to eval.c.orig : File exists
```
```

I didn't actually try to use it as patch input, but I'm not surprised
if it fails. I hit the same problem when I did the rollout patches -
patch simply couldn't deal with a lot of interleaved changes. In that
case I actually used
#if 0
#endif
around the original code and put the new code in afterwards. I'm
almost sure that this is the same problem here.

It's probably not worth worrying about yet. Joseph has mailed me that
he'd prefer a single set of movefilters which apply to all
evaluations, rather than a separate set. As he's the one doing the
changes, I'll follow his lead. I've asked him to send back the changes
he's making - which I assume is to use pointers rather than an array
of filters in the evalcontexts, or maybe simply keeping the filters
entirely separate. Then I'll add something to the GUI - probably under
settings advanced - to set up the filters.

But, if you want, I can send you a copy of eval.c with the changes in
place.

```
```

```

reply via email to