[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnubg] Did I just mess up?

From: Joern Thyssen
Subject: Re: [Bug-gnubg] Did I just mess up?
Date: Mon, 28 Jul 2003 14:53:17 +0000
User-agent: Mutt/1.4.1i

On Mon, Jul 28, 2003 at 04:10:42PM +0200, Holger wrote
> At 01:05 28.07.2003 +0200, Jim Segrave wrote:
> >On Sun 27 Jul 2003 (17:29 +0200), Øystein Johansen wrote:
> >>
> >> I had some trouble with basename and dirname here, so I made a
> >> simplyfied libgen and added to the CVS repository. I may have messed up
> >> the compilation on some systems. Please tell me if something fails.
> >
> >FreeBSD, gtk 2.2 - no problems, no warnings.
> >I think it's Unix clean, now we just need to see if Nardy and Holger
> >have problems.
> No, none at all.   :)
> But on the other hand: in <glib/gutils.h> both 
> g_path_get_dirname/g_path_get_basename are defined. Why not use these? Or 
> are there really systems left without glib?

I don't know, but the answer is probably yes. On one hand is nice to
ensure that gnubg compiles with any plain vanilla ANSI C compiler on a
minimal system, but on the other hand, it would be nice to use some of
the glib stuff, for example:

   char *sz = g_strdup_printf( "blah blah %s %s, foo, bar );
   g_free( sz );

instead of

   char sz[ 100 ]; /* I hope this buffer is large enough */
   sprintf( sz, "blah blah %s %s", foo, bar );


reply via email to

[Prev in Thread] Current Thread [Next in Thread]