Re: [Bug-gnubg] i18n-related issues

[Jon Kinsey]

Petr Kadlec wrote:

> in gtkprefs.c, there are the following lines:
>
>     char* pieceTypeStr[NUM_PIECE_TYPES] = {N_("Rounded disc"), N_("Flat 
> edged disc")};
>     char* textureTypeStr[NUM_TEXTURE_TYPES] = {N_("Top only"), N_("All 
> of piece")};
>
> The strings are marked as translatable, but they are not given to 
> gettext anywhere. I thought I'll fix that, but I've noticed that those 
> strings are not only presented to the user, but also compared (via 
> strcmp) with the user-selected text that comes somehow through GTK 
> (sorry for the fuzzy terminology, I don't know how GTK works). So I was 
> afraid to mess with that.
> Could someone please explain to me if it is OK to just wrap any 
> occurrence of {piece|texture}TypeStr to gettext (even in that strcmp), 
> or if there is some other mechanism to let the strings translate? (Or, 
> maybe, just doing the required changes would be easier than trying to 
> explain GTK to me. :-) )

I used the gtk combo widget, which doesn't seem to remember which option 
you select - hence the strcmps to find the selected option.
One choice would be to change these combo boxes to use option menus and 
then the strcmps could be removed.  I'll have a look, am a bit busy at 
the moment though.

Jon

Ps. You're changes look fine.  warningNames isn't translated though (as 
it's used as a command) so I guess the N_'s aren't needed here.