bug-gnubg
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnubg] Re: What does this function do?


From: Øystein Johansen
Subject: Re: [Bug-gnubg] Re: What does this function do?
Date: Tue, 27 Apr 2004 00:56:41 +0200
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jon Kinsey wrote:

| Øystein Johansen wrote:
|
|> Why not just remove the g_print output? Just let the drawDice2()
|> function return when there is no dice. I think that should be safe and
|> simple.
|
| I've convinced myself that this is ok and made the change, the dice code
| works fine now so unlikely to be any problems anyway.

Ehhh... I see you removed the whole if value <= 0 condition.

You could keep the check and just make the function return, if the value
variable is zero or less. ie. remove the g_print("no value on dice?")
statment.

Could be even safer.

- -Øystein

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFAjZOp6kDTFPhwyqYRAiyAAJwJFP8T1ba6IQAW0SfSKNP0QYbleQCfeY1L
I9WpKzd4wNul/uyb2GR0q84=
=ooIV
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]