[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnubg] Big problems with external player

From: Joern Thyssen
Subject: Re: [Bug-gnubg] Big problems with external player
Date: Fri, 7 May 2004 19:10:40 +0000
User-agent: Mutt/

On Fri, May 07, 2004 at 05:27:29PM +0100, Jon Kinsey wrote
> Jon Kinsey wrote:
> >With this command I do get the error (accept: No such file or 
> >directory), so can look at what is happening.
> I found the bug, it was staring at me (i.e. on the accept line) but a 
> bit obscure.  Anyway I will check in a fix with some better windows 
> error messages in a bit.
> I had to change external_l.c to remove the unistd.h include.

This is somewhat problematic (see below).

> More importantly there seems to be bugs in extparse() which assume 
> szCommand will be at most 100 characters.  The buf[]s need to be 
> increased to 250 - or perhaps a better (none-size related) fix applied.
> It's just luck that it doesn't crash at the moment - all the position 

Whoops! I've committed a fix making buf size-independent.

Unfortunately the <unistd.h> problem requires manual handling. We can
change the code to

#if !WIN32
#include <unistd.h>

but everytime external_l.l is changed we'd have to remember this. Any
good ideas on how to fix this? Is it possible to change your Makefile to
do something like:

cp external_l.c external_l.c~
sed -e 's/^#include <unistd.h>//g' external_l.c~ > external_l.c


reply via email to

[Prev in Thread] Current Thread [Next in Thread]