Re: [Bug-gnubg] BUG: Crash when reviewing sgf file

[Øystein Johansen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jon Kinsey wrote:

| Øystein Johansen wrote:
|
|> BTW Jon? Have you ever experienced bug #9586?
|> http://savannah.gnu.org/bugs/?func=detailitem&item_id=9586
|>
|> I really scratch my head on that one, and when I run it through the
|> debugger, I can't recreate the bug.
|
| I've not been able to recreate this bug, can you get it to go wrong
| outside the debugger?

The problem is that this bug appears some times and some times not. It
happes when a player dance from the bar, but not everytime a player
dances. The assert error comes from line 1793 in play.c. It says

assert(!fComputing)

in the beginning of NextTurn()

The funny thing is that a message window pop up first and says:

player cannot move
player cannot move

(Look at the screenshots in the bugtracker.)

The only function I can imagine creates this message is ShowAutoMove(),
also located in play.c.

It also looks like a new game is started in the game record list, if it
is open.

What I'm trying to find, is the reason ShowAutoMove is called, which
call it is, and what happens from that point on untill NextTurn() is
called.

There is a call to ShowAutoMove() in line 1440. This call is in
ComputerTurn(), so I don't believe it's this call.

There is also a call to ShowAutoMove() in line 1782. This is in
TryBearoff(), so I don't think it's this call either.

Now what about the call to ShowAutoMove() in line 3072? This is in a
function called CommandMove(). This can be it!

Yes! Now I see. I don't remember why, but last time I looked at the bug,
I concluded that this bug happens when ml.cMoves = -1. Can that be
right? Can it be appearing when....

if (!*sz ) line 3006 is true _and_ GenerateMoves return a ml.cMoves that
is -1?

Comments?

If so, What happens to fComputing until NextTurn is called?

- -Øystein

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFBY+ii6kDTFPhwyqYRAm6kAJ9cKaRWL5mC7ZNLbZPHBFi4SFohFACdGCDk
ZpDcuYqVS0b5SCsPfA+l87Y=
=2NU5
-----END PGP SIGNATURE-----