Re: [Bug-gnubg] Problems with the recent changes regarding sounds

[Christian Anthon]

On 12/4/06, Jonathan Kinsey <address@hidden> wrote:
> More generally I don't like #if blocks - they tend to make the code
> tricky to maintain (when used excessively).  Is there any real overhead
> of compiling the sound code (and turning the sound off)?  Similarly some
> of the other blocks - time controls for example, could easily be
> included in all builds?

I agree that the code contains too many #if's. Here the sound code is
fairly isolated, so blocking everything actually takes fewer #if's.

I wouldn't mind if the sound code was always included, but then we
should make separate sound options for the cli and the gui.

Christian.