Re: [Bug-gnubg] New feature - Batch analysis!

[Øystein Johansen]

Christian Anthon wrote:
> yes we have needed this feature for a long time, but Jon's
> implementation of auto recognition of the file format has made it a
> lot easier.

Yes, without his code it would not have been easy.

> > I've put the menu item under Analysis/Batch analysis. Should it rather
> > have been under 'Files'? Any opinions?
>
> My opinion is  that the menus need an overhaul. Perhaps unifying the
> menu and the toolbar through gtkuimanager?

Yes, yes! Music to my ears....

BTW. The menu system is not the only thing that needs an overhaul.

> > * What about the sound? Can we temporary set the
> >    analysisfinished sound to None? Not really nice, though....
>
> That's a minor issue I think. Disabling it and just playing it in the
> end sounds like a good idea.

Eh. Adding a new input to AnalyseMatch(), a boolean fPlaySound?
Whatever...

> > * What happens if someone cancels the analysis... ?
> >    (This question is really important if we toggle a global variable)
>
> A much more important point. Ideally, canceling the whole batch and
> just skipping ahead to the next match should both be possible.

Yes! there should be a system handling cancels. A batch analyse is a 
long process, so many user will want to cancel or pause it.

> > * A progress dialog might be better than the progress bar in
> >    the statusline.
>
> I think so yes.

Need more than 50 lines though.... later...

> A few other points. Does the batch analysis overwrite the original
> file and how easy is it to make a new analysis of the same match?

I'm not sure.... Not tested much.

-Øystein