[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnulib] dirname.h self-contained?

From: Bruno Haible
Subject: Re: [Bug-gnulib] dirname.h self-contained?
Date: Tue, 27 May 2003 22:00:18 +0200 (CEST)

Paul Eggert writes:

> Here's a proposed patch to gnulib to simplify the code a bit (and help
> forestall the question that started this thread) by assuming the
> above-listed headers.  I haven't changed the modules imported from
> glibc, nor the modules that I know are used by Emacs (it still wants
> portability to K&R, right?)


Glad to see this old cruft go away. Your patch looks good, except for:

- error.c and fnmatch.c which are shared with glibc and which
  according to your above reasoning you would like to exclude from
  the modernization?

- localcharset.c which is used in libintl, and libintl needs to
  maintain K&R C compatibility as long as the GCC sources maintain K&R C
  compatibility. So please could you drop the changes to
  localcharset.c and localcharset.m4 ?

Also I note that I had forgotten to check for limits.h in exclude.m4.
This bug was unnoticed and now goes away without having hurt anyone.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]