[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnulib] "# " versus " #" when indenting preprocessor directives

From: Jim Meyering
Subject: Re: [Bug-gnulib] "# " versus " #" when indenting preprocessor directives
Date: Tue, 12 Aug 2003 05:23:33 +0200

Paul Eggert <address@hidden> wrote:

> Bruno Haible <address@hidden> writes:
>> "maintaining a consistent style of code formatting [is a] very worthy goal".
> I quite agree, as do the GNU coding standards.  The issue is whether
> it's worth the effort to change the style (consistently, of course).
> I think a large majority prefers the " #" style, once we remove the
> constraint of porting to K&R C.
> I'm willing to make the switch in gnulib and the programs I help
> maintain (except for the rare exceptional modules that still require
> K&R compatibility).  But I don't want to make the change if it will
> seriously inconvenience other gnulib users.

I too am willing to make the switch with coreutils, but will first
have to change cppi (or use GNU indent) so that I can enforce
the new style on a commit-hook for coreutils.  It'll take me a
while to teach my fingers the new style :-)

This raises the issue of what to do with sources that come from
elsewhere, mainly glibc.  Maybe we can simply automate the
transformation when syncing from there to gnulib.

I do have mixed feelings about this.  I prefer the newer style,
but know from experience that making any such global formatting
change obscures all preceding version-control history for the
affected lines. That can be annoying.  It certainly makes digging
through the version-control history more tedious.

But I suppose it's worth it.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]