[Bug-gnulib] Re: Bug#177940: mktime.c fix

[Ben Pfaff]

Otavio Salvador <address@hidden> writes:

> || On Fri, 22 Oct 2004 12:54:34 +0900
> || GOTO Masanori <address@hidden> wrote: 
>
> gm> Hi,
> gm> At 30 Dec 2003 23:49:22 -0800,
> gm> Paul Eggert wrote:
>>> Jeff Bailey <address@hidden> writes:
>>> 
>>> > It's been a while since I've looked at this, but it appears that the
>>> > files should be identical, right?  (All the #ifdef _LIBC constructs are
>>> > still in place).  If yes, I can put together a series of patches to get
>>> > it back in sync.
>>> 
>>> Thanks for volunteering!  But I really should do it, since I wrote
>>> mktime.c and understand the patches well.
>>> 
>>> I'll send the proposed patches to libc-alpha, since Ulrich won't let
>>> me send email to libc-hacker.  If nothing happens for a while, I
>>> suppose that you can copy the patches to libc-hacker.
>
> gm> Is this patch still needed?
>
> I'm not sure. I didn't test it since the report.

I reran the test that I did for the original bug report and still
see the error even with the latest `unstable' libc6 in Debian
(2.3.2.ds1-18).  In fact it appears to be worse because now it
reports that mktime doesn't work for every timezone I tried
(America/Sao_Paulo, US/Pacific, GMT), e.g.:

    address@hidden:~/tmp$ TZ=GMT ./configure
    checking for gcc... gcc
    checking for C compiler default output file name... a.out
    checking whether the C compiler works... yes
    checking whether we are cross compiling... no
    checking for suffix of executables... 
    checking for suffix of object files... o
    checking whether we are using the GNU C compiler... yes
    checking whether gcc accepts -g... yes
    checking for gcc option to accept ANSI C... none needed
    checking whether time.h and sys/time.h may both be included... yes
    checking how to run the C preprocessor... gcc -E
    checking for egrep... grep -E
    checking for ANSI C header files... yes
    checking for sys/types.h... yes
    checking for sys/stat.h... yes
    checking for stdlib.h... yes
    checking for string.h... yes
    checking for memory.h... yes
    checking for strings.h... yes
    checking for inttypes.h... yes
    checking for stdint.h... yes
    checking for unistd.h... yes
    checking for stdlib.h... (cached) yes
    checking sys/time.h usability... yes
    checking sys/time.h presence... yes
    checking for sys/time.h... yes
    checking for unistd.h... (cached) yes
    checking for alarm... yes
    checking for working mktime... no
    configure: creating ./config.status
-- 
Ben Pfaff 
email: address@hidden
web: http://benpfaff.org