Re: [bug-gnulib] [PATCH] small cleanup of gnulib-tool

[Stepan Kasal]

Hello Paul,

On Tue, Dec 14, 2004 at 09:55:45AM -0800, Paul Eggert wrote:
> Stepan Kasal <address@hidden> writes:
> > +           sed -e 
> > 's,lib_\(SOURCES\|OBJECTS\|LIBADD\),'"${libname}_${libext}"'_\1,g' 
> 
> That doesn't look portable.  POSIX says \| has undefined behavior in a
> sed regular expression.

oh, so I would need
      sed -e 's,lib\(_[A-Z][A-Z]*\),'"${libname}_${libext}"'\1,g'

I have verified that modules/* doesn't contain any occurence of
lib_SOMETHING which would be broken by this.

Should I list the letters?  Is gnulib-tool supposed to run on EBCDIC hosts?

> Also, the original doesn't mention LIBADD, but the replacement does.
> How come?

A proposed patch added it.  That was why I thought the command was going
to be too long and needs a cleanup.

Have a nice day,
        Stepan