Re: AC 2.59 incompatibility in getaddrinfo.h

[Simon Josefsson]

Derek Price <address@hidden> writes:

> Is there any reason I can't just assume gl_GETADDRINFO ran and config.h
> was included before getaddrinfo.h?  The following test is always coming
> up false on platforms without getaddrinfo (as of AC 2.59, at least,
> AC_CHECK_FUNCS via AC_REPLACE_FUNCS leaves HAVE_GETADDRINFO undefined
> when it is not found):
>
> # if defined HAVE_GETADDRINFO && !HAVE_GETADDRINFO
>
> [...decl struct addrinfo & many macros...]
>
> # endif
>
>
> The possible fixes are fixing gl_GETADDRINFO to "#define
> HAVE_GETADDRINFO 0" when getaddrinfo isn't found or shortening the above
> test to: "# if !HAVE_GETADDRINFO", and I'd rather just simplify the
> header unless there is good reason to leave it as is, especially as
> other naive code with GNULIB installed may be already using "#ifdef
> HAVE_GETADDRINFO" somewhere.

I used that style in the header file because the automake manual
suggested it, but in gnulib I now think simply using #if
!HAVE_GETADDRINFO would be fine.