bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: one more warning in argp-help


From: Eric Blake
Subject: Re: one more warning in argp-help
Date: Sat, 10 Dec 2005 15:22:52 -0700
User-agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Jim Meyering on 12/10/2005 3:19 PM:
> Removing trailing blanks is a worthy goal, but it is better never to
> mix white-space-only changes and any other type of change.  The white-
> space-only hunks make it hard to find the significant part of the patch.

Resend, with no whitespace differences (I know that diff -b sometimes
messes up indenting, but in this case, it worked).

2005-12-10  Eric Blake  <address@hidden>

        * argp-help.c (__argp_failure) [USE_IN_LIBIO || _LIBC ||
        HAV_DECL_STRERROR_R]: Only declare buf when used, to avoid
        compiler warning.

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDm1U884KuGfSFAYARApFsAJ9jbD/dnmY9XqCrN8Wi/+NONqf2UQCgs1Am
BBQtFly+1yLUWJKRAJiDWm4=
=THjV
-----END PGP SIGNATURE-----
Index: lib/argp-help.c
===================================================================
RCS file: /cvsroot/gnulib/gnulib/lib/argp-help.c,v
retrieving revision 1.20
diff -u -p -b -r1.20 argp-help.c
--- lib/argp-help.c     10 Dec 2005 21:37:29 -0000      1.20
+++ lib/argp-help.c     10 Dec 2005 22:21:42 -0000
@@ -1892,7 +1892,9 @@ __argp_failure (const struct argp_state 
 
          if (errnum)
            {
+#if defined USE_IN_LIBIO || _LIBC || HAVE_DECL_STRERROR_R
              char buf[200];
+#endif
 
 #ifdef USE_IN_LIBIO
              if (_IO_fwide (stream, 0) > 0)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]