bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug in readutmp module


From: Bruno Haible
Subject: bug in readutmp module
Date: Tue, 10 Jan 2006 14:22:59 +0100
User-agent: KMail/1.5.4

Jim,

"gnulib-tool --create-megatestdir --dir=/dev/shm/testdir --with-tests"
shows this:

configure.ac:20: warning: gl_FUNC_FREE is m4_require'd but is not m4_defun'd
configure.ac:20: gl_FUNC_FREE is required by...
m4/readutmp.m4:55: gl_READUTMP is expanded from...

The reason is that m4/readutmp.m4 invokes gl_FUNC_FREE, but m4/free.m4 is not
part of this module or its dependencies.

Here is a fix. OK to commit?


2006-01-08  Bruno Haible  <address@hidden>

        * m4/readutmp.m4 (gl_READUTMP): Don't require gl_FUNC_FREE. Use a
        module dependency instead.
        * modules/readutmp: Depend on module free.

*** m4/readutmp.m4.bak  2005-05-02 13:27:38.000000000 +0200
--- m4/readutmp.m4      2006-01-08 15:30:53.000000000 +0100
***************
*** 1,5 ****
! # readutmp.m4 serial 9
! dnl Copyright (C) 2002, 2003, 2004, 2005 Free Software Foundation, Inc.
  dnl This file is free software; the Free Software Foundation
  dnl gives unlimited permission to copy and/or distribute it,
  dnl with or without modifications, as long as this notice is preserved.
--- 1,5 ----
! # readutmp.m4 serial 10
! dnl Copyright (C) 2002, 2003, 2004, 2005, 2006 Free Software Foundation, Inc.
  dnl This file is free software; the Free Software Foundation
  dnl gives unlimited permission to copy and/or distribute it,
  dnl with or without modifications, as long as this notice is preserved.
***************
*** 11,17 ****
  
    dnl Prerequisites of lib/readutmp.h and lib/readutmp.c.
    AC_REQUIRE([AC_C_INLINE])
-   AC_REQUIRE([gl_FUNC_FREE])
    AC_CHECK_HEADERS_ONCE(utmp.h utmpx.h)
    AC_CHECK_FUNCS_ONCE(utmpname utmpxname)
    AC_CHECK_DECLS(getutent,,,[
--- 11,16 ----
*** modules/readutmp.bak        2005-05-09 16:27:12.000000000 +0200
--- modules/readutmp    2006-01-08 15:31:09.000000000 +0100
***************
*** 8,13 ****
--- 8,14 ----
  
  Depends-on:
  xalloc
+ free
  stdbool
  
  configure.ac:






reply via email to

[Prev in Thread] Current Thread [Next in Thread]