Re: [bug-gnulib] Re: portability fix for bison-1.75

[Bruno Haible]

Paul Eggert wrote:
>       (__strndup): Revert to K&R-style function dfns, the glibc style.

Huh? We know the problems of K&R-style function definitions: arguments
of type 'float', 'short' and 'char' are implicitly promoted, leading to
a clash with the function prototype. Empty argument lists allow calls
later in the same compilation unit with argument, if no '(void)'
protype was seen. - Wouldn't it be better to move the glibc source code
to ANSI C?

>       * lib/strnlen.c: Don't claim it's taken from glibc; it's not.

It was taken from glibc/string/strnlen.c in 2000 or 2001, but glibc has
diverged since then, moving the file to glibc/sysdeps/generic/strnlen.c
and now back to glibc/string/strnlen.c.

How about this additional patch?

*** modules/strnlen     9 Jan 2006 21:40:18 -0000       1.6
--- modules/strnlen     24 Jan 2006 19:42:27 -0000
***************
*** 20,24 ****
  LGPL
  
  Maintainer:
! glibc
  
--- 20,24 ----
  LGPL
  
  Maintainer:
! all
  
*** config/srclist.txt  24 Jan 2006 14:06:47 -0000      1.113
--- config/srclist.txt  24 Jan 2006 19:42:27 -0000
***************
*** 259,265 ****
  #$LIBCSRC/string/strcasecmp.c                 lib gpl
  #$LIBCSRC/string/strchrnul.c                  lib gpl
  #$LIBCSRC/string/strerror.c                   lib gpl
- #$LIBCSRC/string/strnlen.c                    lib gpl
  #$LIBCSRC/sysdeps/posix/gettimeofday.c                lib gpl
  #$LIBCSRC/sysdeps/posix/rename.c              lib gpl
  #$LIBCSRC/sysdeps/unix/mkdir.c                        lib gpl
--- 259,264 ----