[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: read-file

From: Simon Josefsson
Subject: Re: read-file
Date: Fri, 16 Jun 2006 21:38:56 +0200
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux)

Aaron Stone <address@hidden> writes:

> On Fri, 2006-06-16 at 11:18 -0700, Paul Eggert wrote:
>> Simon Josefsson <address@hidden> writes:
>> > +  if (buf)
>> > +    buf[size] = '\0';
>> The file reading code returns NULL if the file was empty?  But the
>> comments makes it sound like it will return xstrdup (""), and that
>> would be more consistent.  You might also add a test case, to read
>> from /dev/null.
> If I were using a function like this, I'd expect NULL on error (and
> errno set according to fopen), and an empty string if the file is empty.

Yup.  That's the intention.  (Of course, other functions may set errno
too, if, e.g., malloc or fclose fails.)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]