[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: last trim code

From: Bruno Haible
Subject: Re: last trim code
Date: Mon, 4 Sep 2006 18:56:36 +0200
User-agent: KMail/1.9.1

[Re-added bug-gnulib in CC.]

Hello Davide,

Thanks for the new code. Looks quite good now. The second loop, however,
will crash when passed a string consisting entirely of whitespace.

I see also you've partially adopted the GNU style for this code. Fine!
Indeed, before we put code into gnulib, we reindent it to GNU style. Another
element of this style is to put a space before the opening parenthesis
of function definitions, function calls and macro calls:
      for (; mbi_avail (i) && mb_isspace (mbi_cur (i)); mbi_advance (i))

This and the handling of platforms without multibyte functions (see my
last mail), and the code is ready for committing.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]