[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: unused variables and other nits in gnulib/m4

From: Jim Meyering
Subject: Re: unused variables and other nits in gnulib/m4
Date: Fri, 22 Sep 2006 09:03:40 +0200

Ralf Wildenhues <address@hidden> wrote:
> Hello Simon, Jim, Paul, Bruno, all,
> OK to apply these patches to make
>   ./configure CC='gcc -Wall -Werror -fno-builtin'
> work better (tested on GNU/Linux) with these tests?
> (Mind you, I haven't tested any of these changes on other systems.)

Hi Ralf,
Thanks for the clean-up.  Those look fine, overall.
A couple of nits:
- fsusage.m4 needs a serial number update.
- at least one other file does, too.
- mkdir-slash.m4's serial number was incremented twice :-)
- for those that now include unistd.h,
    add AC_CHECK_HEADERS_ONCE(unistd.h),
    or maybe even AC_REQUIRE([gl_HEADER_UNISTD]),
    or just depend on the `unistd' module and drop the #ifdefs,
    though I'm not sure the last will work for configure-time compiles.

How did you test these changes?
I've found it useful to compare the following (e.g., via coreutils),
before and after the change:
  ./configure output

reply via email to

[Prev in Thread] Current Thread [Next in Thread]