[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: vc-dwim 0.2: a version-control-agnostic ChangeLog diff and commit to

From: Ralf Wildenhues
Subject: Re: vc-dwim 0.2: a version-control-agnostic ChangeLog diff and commit tool
Date: Fri, 22 Sep 2006 14:45:39 +0200
User-agent: Mutt/1.5.13 (2006-09-01)

Hello Jim,

* Jim Meyering wrote on Fri, Sep 22, 2006 at 09:58:26AM CEST:
>   hg clone http://hg.et.redhat.com/hg/emd/applications/vc-dwim
> If you know of a similar tool, or a nice, VC-agnostic perl module,
> please let me know.

cl-commit seems to do a subset of what you advertise.  I say seems

> Feedback welcome,

... I can't get it to build.  Even after I updated by `hg' tool to the
latest version of http://selenic.com/hg/ (advertised as 0.7), its `hg
log' function does not understand `--limit' nor `--template', thus the
sed expression to create vc-dwim ends up being invalid.  The `hg' tool
furthermore seems not to work outside a checked-out directory (a
  cd $(srcdir) && hg ...
should fix that).

Next, $< is not portable to use except in inference rules.

Also, the `$((' in
  $((./vc-dwim --print-vc-list) 2>/dev/null || echo cg cvs hg svn)

is erroneous (see (autoconf.info)Shell Substitutions).

    perllibdir="`cd $(top_srcdir); pwd`" \

is dangerous, as shells may produce output upon the `cd'.  Using

aka. $(am__cd) (undocumented(!) Automake variable) instead works.

On the formal side, many files lack a copyright header; vc-dwim.pl
refers to the LGPL but only the GPL is shipped with the tarball; and I
missed AUTHORS (certainly not a requirement), and a statement in README
stating which license applies to it.

I haven't had a chance to take a look at your tool's functionality yet.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]