bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Building m4 on BSDI 4.0.1


From: Eric Blake
Subject: Re: Building m4 on BSDI 4.0.1
Date: Tue, 09 Jan 2007 06:04:36 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.9) Gecko/20061207 Thunderbird/1.5.0.9 Mnenhy/0.7.4.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Paul Eggert on 1/9/2007 12:23 AM:
> Eric Blake <address@hidden> writes:
> 
>>     BSD/OS 4.1 has a bug: <stdio.h> and <time.h> must be included before
>> -   <wchar.h>.  */
>> +   <wchar.h>.
>> +   BSDI 4.0.1 has a bug: <stddef.h> must be included before <wchar.h>.  */
>> +# include <stddef.h>
> 
> That patch looks fine to me, except that the comment should say
> "BSD/OS" rather than "BSDI".  The operating system was named "BSD/OS";
> "BSDI" was the name of the company.

I'm still awaiting confirmation from Chris that it indeed fixes his
problem.  If so, there are more places in gnulib that should be similarly
patched - a number of .m4 files are rather cavalier about
AC_CHECK_HEADERS_ONCE([wchar.h]), which gets the dreaded 'present but
cannot be compiled' error in these sorts of situations.  wcwidth.m4 has
the right approach (but needs the same addition of <stddef.h>); maybe it
is worth factoring out wchar.m4 into its own file and using that from all
other modules that use wchar_t or <wchar.h>.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFo5Lk84KuGfSFAYARAlXRAJ99UcecSa1ifXDGWRr79WV2mA1UdwCgkepP
6Jxj1O9JCxwONujrMzfR2Aw=
=pvxh
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]