[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: snprintf gnulibification, first step

From: Daniel Jacobowitz
Subject: Re: snprintf gnulibification, first step
Date: Fri, 23 Feb 2007 23:54:10 -0500
User-agent: Mutt/1.5.13 (2006-08-11)

On Fri, Feb 23, 2007 at 11:42:31PM -0500, Daniel Jacobowitz wrote:
> I checked in the attached to libsnprintfv.

By the way, the only warning in the mingw32 build:

../../libsnprintfv/snprintfv/printf.c: In function `stream_vprintf':
../../libsnprintfv/snprintfv/printf.c:850: warning: `snv_wint_t' is
promoted to `int' when passed through `...'
../../libsnprintfv/snprintfv/printf.c:850: warning: (so you should
pass `int' not `snv_wint_t' to `va_arg')
../../libsnprintfv/snprintfv/printf.c:850: note: if this code is
reached, the program will abort

This comes from a 16-bit wint_t which needs to further promote to int.
The printf-parse.c already in gnulib has a fix for this, so I imagine
we'll be back to it one way or another.

I also checked in this, since it bit me.

Daniel Jacobowitz

2007-02-23  Daniel Jacobowitz  <address@hidden>

        * tests/Makefile.am (snprintfv_test_DEPENDENCIES): Set.

Index: tests/Makefile.am
RCS file: /sources/libsnprintfv/libsnprintfv/tests/Makefile.am,v
retrieving revision 1.7
diff -u -p -r1.7 Makefile.am
--- tests/Makefile.am   24 Feb 2007 04:34:52 -0000      1.7
+++ tests/Makefile.am   24 Feb 2007 04:53:01 -0000
@@ -86,5 +86,6 @@ regress_test_SOURCES  = regress-test.c
 stream_test_SOURCES    = stream-test.c
 snprintfv_test_SOURCES = snprintfv-test.c
 snprintfv_test_LDFLAGS = -dlpreopen piglatin.la
+snprintfv_test_DEPENDENCIES = piglatin.la
 # Makefile.am ends here

reply via email to

[Prev in Thread] Current Thread [Next in Thread]