[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: coreutils build on IRIX 6.5

From: Jim Meyering
Subject: Re: coreutils build on IRIX 6.5
Date: Sat, 24 Feb 2007 09:26:49 +0100

Bruno Haible <address@hidden> wrote:
> 2007-02-23  Bruno Haible  <address@hidden>
>       * m4/perl.m4 (gl_PERL): Require version 5.005, not 5.003. Needed for
>       help2man.
>       * man/Makefile.am (.x.1): If the autoconf test has determined that
>       perl is missing or not a sufficient version, do nothing.

Thanks yet again.
Applied, part in coreutils and part in gnulib.

Also, I added a warning, as you proposed.

But noticed a problem.  Although "case $(PERL)" often works,
and looks ok because we know "case $shell_var" does not
require quotes around $shell_var, here $(PERL) must be quoted,
because it is expanded by make.

So I checked in this additional change:

        Avoid a shell syntax error, when building with an inadequate Perl.
        * man/Makefile.am (.x.1): Add quotes around $(PERL) in case, since
        it can expand to "/.../missing perl".

diff --git a/man/Makefile.am b/man/Makefile.am
index 17b3415..32df9d1 100644
--- a/man/Makefile.am
+++ b/man/Makefile.am
@@ -153,7 +153,7 @@ mapped_name = `echo $*|sed 's/install/ginstall/; s/test/[/'`
 # That is necessary to avoid failures for programs that are also shell built-in
 # functions like echo, false, printf, pwd.
-       @case $(PERL) in                                        \
+       @case '$(PERL)' in                                      \
          *"/missing "*)                                        \
            echo 'WARNING: cannot update man page $@ since perl is missing' \
              'or inadequate' 1>&2 \

reply via email to

[Prev in Thread] Current Thread [Next in Thread]