[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gnulib-tool incorrectly handles library names with dashes
From: |
Jim Meyering |
Subject: |
Re: gnulib-tool incorrectly handles library names with dashes |
Date: |
Thu, 05 Jul 2007 12:10:37 +0200 |
"Sergey Poznyakoff" <address@hidden> wrote:
...
> 2007-07-05 Sergey Poznyakoff <address@hidden>
>
> * gnulib-tool (func_dest_tmpfilename)
> (func_create_testdir): Translate `-' in file names to `_' in
> variable names.
> (func_import): Avoid duplication of --avoid statements
>
> Index: gnulib-tool
> ===================================================================
...
> - avoidlist=`echo $cached_avoidlist $avoidlist`
> + avoidlist=`echo $cached_avoidlist $avoidlist | tr ' ' '\n' | sort | uniq |
> tr '\n' ' '`
Hi Sergey,
I noticed a couple nits.
You might prefer to use '\012' in place of '\n'.
Some old, non-GNU versions of tr don't honor '\n'.
Also, you can save a process by using "sort -u" rather than "sort|uniq".
And the convention is to specify the locale: "LC_ALL=C sort".