[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch for the getpagesize module
From: |
Martin Lambers |
Subject: |
Re: Patch for the getpagesize module |
Date: |
Mon, 3 Dec 2007 14:21:58 +0100 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Mon, Dec 03, 2007 at 12:39:15PM +0100, Bruno Haible wrote:
> > MinGW has a getpagesize() function, but does not declare it.
>
> Strange. The mingw system I have access to does not have a getpagesize()
> function. In yours, in which library is it defined? And what is your mingw
> system? MSYS, Cygwin-crosscompiled, or Debian-crosscompiled?
It seems to be only in libgcc.a, both in MinGW-5.1.3+MSYS and
Debian-crosscompiled (version 3.4.5.20060117.1.dfsg-2 from etch).
How should this be handled?
> > I removed the untested MSVC implementation from the previous patch.
>
> Actually, I think it's better to treat mingw and MSVC systems the same
> where possible.
>
> The implementation that you gave in your previous patch
>
> #if (defined _WIN32 || defined __WIN32__) && ! defined __CYGWIN__
> SYSTEM_INFO system_info;
> GetSystemInfo (&system_info);
> return system_info.dwPageSize;
>
> is the same as the one used in GNU clisp for 10 years, so you can assume
> that it works. (And its value on 32-bit x86 platforms is 0x1000.)
>
> I would therefore find it reasonable to create a lib/getpagesize.c file
> just for this case of native Windows. What do you think?
Yes, but I'm not sure how the conditional compilation of this file
should be handled.
Should getpagesize.m4 call AC_LIBOBJ([getpagesize]) only on W32?
Or should it be compiled for all systems lacking getpagesize(), and only
provide a definition for W32?
Martin
- Re: Patch for the getpagesize module, Bruno Haible, 2007/12/03
- Re: Patch for the getpagesize module, Bruno Haible, 2007/12/03
- Re: Patch for the getpagesize module,
Martin Lambers <=
- Re: Patch for the getpagesize module, Bruno Haible, 2007/12/04
- Re: Patch for the getpagesize module, Martin Lambers, 2007/12/04
- Re: Patch for the getpagesize module, Bruno Haible, 2007/12/07
- Re: Patch for the getpagesize module, Martin Lambers, 2007/12/10
- Re: Patch for the getpagesize module, Bruno Haible, 2007/12/26
Re: Patch for the getpagesize module, Jim Meyering, 2007/12/03