[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Some free()s in module 'relocatable'
From: |
Ben Pfaff |
Subject: |
Re: Some free()s in module 'relocatable' |
Date: |
Wed, 26 Dec 2007 13:10:02 -0800 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) |
Sylvain Beucler <address@hidden> writes:
> Attached is a small patch to fix a couple non-fred memory blocks. They
> are not a big deal, but they do produce noise when analyzing programs
> with memory checkers such as Valgrind.
I do not see the attachment.
> Another thing:, the relocatable module documentation recommends using:
> bindtextdomain (PACKAGE, relocate (LOCALEDIR));
> however, the result of relocate may be LOCALEDIR itself (no
> relocation) or a newly allocated string.
[...]
> Maybe it would be cleaner to always return a newly allocated string?
This does seem reasonable to me, but I will wait to hear Bruno's
opinion before I do anything.
--
Ben Pfaff
http://benpfaff.org