[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] conditions variables module

From: Bruno Haible
Subject: Re: [PATCH] conditions variables module
Date: Thu, 7 Aug 2008 11:15:15 +0200
User-agent: KMail/1.5.4

Hi Yoann,

> Attached is an initial implementation of the glcond module, based on
> your lock module. 

I like about it that its API is in the same spirit as 'lock' and 'tls'.

A unit test and a Woe32 implementation are still missing.

The prefix 'gl' for the module and header file is probably unnecessary:
most modules are gnulib modules anyway, and if the header was called "cond.h",
there would not be much risk of collision either.

The comments still talk about "Locking" and me as the author.

I would also mention in a comment the distinction between "condition variable"
and "wait queue" done in [1].


[1] http://www.helenos.eu/doc/design/html.chunked/sync.html#id2531858

reply via email to

[Prev in Thread] Current Thread [Next in Thread]