[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: checkin of glthread/glcond modules

From: Bruno Haible
Subject: Re: checkin of glthread/glcond modules
Date: Wed, 13 Aug 2008 11:59:43 +0200
User-agent: KMail/1.5.4

Hello Yoann,

> I'm wondering whether there is a problem with the last set of patch I
> sent you on the mailing list, that may prevent you from checking them
> in?

Sorry, I had zero time from Friday to Monday.

Your patch looks quite good. Thanks for the many updates. (Only the test-lock
part has useless reformatting.)

But the major points I'm still hesitating about are:
  - What about the module for the sched_yield function, which is mandatory
    for code that runs with GNU Pth? Do you write it, or should I write it?
  - 'gl' prefix of the module names? I vote for no, since all modules are
    gnulib modules, and it's thus redundant.
  - 'gl' prefix of the header files? You are right that because of
    Solaris <thread.h> "it make sense to use glcond / gllock to use the same
    convention everywhere". But I have a bad feeling about such a renaming.
    Can you see alternatives? Maybe something like <glthread/lock.h>,
    <glthread/tls.h>, <glthread/thread.h>, <glthread/cond.h>,
    <glthread/yield.h> ?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]