[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] use new global, "Version", rather than macro, VERSION

From: Eric Blake
Subject: Re: [PATCH] use new global, "Version", rather than macro, VERSION
Date: Thu, 28 Aug 2008 06:35:30 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20080708 Thunderbird/ Mnenhy/

Hash: SHA1

According to Jim Meyering on 8/28/2008 5:54 AM:
> This change makes ccache (http://ccache.samba.org/) more useful in
> that cached .o files from one build are usually still useful after a
> version number change.  Before, due to the use of VERSION, the old .o
> files would be useless and just pollute the cache.
> This first patch uses version-controlled files named
> src/version.[ch].  The second change-set makes it so they
> are generated, and hence not version-controlled.
> Comments or suggested improvements welcome.

This is EXACTLY the heart of the matter impacting the GNUmakefile
discussion.  In your second patch, why is version.h generated?  In
reality, only version.c needs to be generated, since it is the only file
with varying contents.

> * src/Makefile.am: Put it in a library that everyone links to.
> (noinst_LIBRARIES, libver_a_SOURCES): Define.
> (LDADD): Add libver.a.

Is the library a necessity, or is version.o sufficient?

> +BUILT_SOURCES += version.c
> +version.c: Makefile
> +     rm -f $@
> +     printf '#include <config.h>\n' > address@hidden
> +     printf 'char const *Version = "$(PACKAGE_VERSION)";\n' >> address@hidden
> +     @chmod a-w address@hidden
> +     mv address@hidden $@

Oops.  This still doesn't solve the GNUmakefile debate.  For this design
to solve that issue, you need to use something other than PACKAGE_VERSION,
so that you can guarantee that config.h is not polluted with version
changes.  Is it worth calling git-version-gen directly?

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


reply via email to

[Prev in Thread] Current Thread [Next in Thread]