[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] gnulib-tool: fix sed-based filtering

From: Jim Meyering
Subject: [PATCH] gnulib-tool: fix sed-based filtering
Date: Fri, 02 Jan 2009 19:47:09 +0100

Part of this change,

  Speed up gnulib-tool by doing more string processing through shell built-ins.

contained an error that made gnulib-tool fail with shells
that use the  fast_func_remove_prefix=false (sed-using) code path.
That probably includes most shells other than bash and zsh.
I noticed it with ubuntu's dash-based /bin/sh.

It would put lines like this:

  EXTRA_DIST += lib/xstrtoumax.c

in the generated lib/Makefile.am, instead of this:

  EXTRA_DIST += xstrtoumax.c

Obviously, that didn't work.

Here's the fix I'll push shortly, if no one objects.

>From 8d90fcc8c796b2a3c7696ec4a39105d7a9525903 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Fri, 2 Jan 2009 19:29:30 +0100
Subject: [PATCH] gnulib-tool: fix sed-based filtering

* gnulib-tool (func_filter_filelist): Remove extra backslash
in sed_fff_filter definition.
 gnulib-tool |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gnulib-tool b/gnulib-tool
index 4b66367..965f516 100755
--- a/gnulib-tool
+++ b/gnulib-tool
@@ -1408,7 +1408,7 @@ func_filter_filelist ()
-    sed_fff_filter="s|^$6\(.*\)$7\\$|$8\\1$9|"
+    sed_fff_filter="s|^$6\(.*\)$7\$|$8\\1$9|"
     ffflist=`for fff in $3; do
                case "$fff" in
                  "$4"*"$5") echo "$fff" ;;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]