bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ld-output-def


From: Eric Blake
Subject: Re: ld-output-def
Date: Wed, 01 Apr 2009 06:26:09 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.21) Gecko/20090302 Thunderbird/2.0.0.21 Mnenhy/0.7.6.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Simon Josefsson on 3/31/2009 10:56 PM:
>     AC_MSG_RESULT($gl_output_def)
>     LDFLAGS="$gl_ldflags_save"
>   fi
>   AM_CONDITIONAL(HAVE_LD_OUTPUT_DEF, test "$gl_output_def" = "yes")

Still missing m4 quoting.  On the other hand, shell quotes around yes are
redundant (although harmless).

    AC_MSG_RESULT([$gl_output_def])
    LDFLAGS="$gl_ldflags_save"
  fi
  AM_CONDITIONAL([HAVE_LD_OUTPUT_DEF], [test "$gl_output_def" = yes])

Also, any reason why you are not using an AC_CACHE_VAL (or even
AC_CACHE_CHECK, with the contents of the cache variable being used as your
followup message)?  Without using the cache, you are paying the cost of a
link test on every subsequent configure run?

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknTXWEACgkQ84KuGfSFAYCuEgCgsJMVv5+0VdhqBJIMVqw8E0ml
/GoAn1XWj6foKBosmWvgj4bAxcku225P
=uFhO
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]