[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maintainer-makefile: (PO_DOMAIN): New variable, allows overr

From: Jim Meyering
Subject: Re: [PATCH] maintainer-makefile: (PO_DOMAIN): New variable, allows overriding of gettext domain.
Date: Fri, 17 Apr 2009 09:17:01 +0200

Simon Josefsson wrote:
> This is useful in gnutls, which uses a different gettext domain than the
> top-level package name.  Pushed.

Hi Simon,

That looks fine.

However, note that it downloads all .po files every time.  Have you
considered adjusting that rule to work like the code in bootstrap, that
uses rsync and a cache?  That avoids not only the wasteful re-download
when things haven't changed, but also the relatively expensive updates
that would be required when .po file time stamps change unnecessarily.

Note that bootstrap too assumes $package == $domain,
so it would need a similar change to be useful for you.

I've just merged a tiny change from gnulib's build-aux/bootstrap
into coreutils' bootstrap, and will merge the other way today or
tomorrow: there have been several bug fixes and improvements.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]