[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Use automake *-local hooks as prerequisites only

From: Bruno Haible
Subject: Re: Use automake *-local hooks as prerequisites only
Date: Fri, 1 May 2009 21:54:07 +0200
User-agent: KMail/1.9.9

Hi Ralf,

> a limitation in that this strategy is not extensible: two
> sets of commands for one rule produce an error from 'make'.  This can
> be avoided by creating module-private targets for the actual rule with
> commands

Good point. I wasn't aware about this subtle point when I wrote the rules

> If you need a blurb about this in some gnulib documentation then please
> show me where it would be appropriate; thanks.

It's more in the automake documentation that I would expect this. There
I read:

   For instance, here is one way to erase a subdirectory during `make
clean' (*note Clean::).

             -rm -rf testSubDir

Here you could add that a more extensible way of writing this is

     clean-local: clean-local-testSubDir
             -rm -rf testSubDir

> OK to push?

Without the .PHONY, please. If someone ever has an unintended overlap
between file names on disk and Makefile targets, he's better off renaming
one or the other, instead of relying on obscure 'make' features.

Also I would rename the targets
     install-exec-charset -> install-exec-localcharset
     uninstall-charset -> uninstall-localcharset
because the name of the module is 'localcharset'.

Thanks for this improvement!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]