[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: glob: mingw failures

From: Bruno Haible
Subject: Re: glob: mingw failures
Date: Sat, 2 May 2009 13:58:50 +0200
User-agent: KMail/1.9.9

Hi Simon,

> The reason is the fnmatch module doesn't create fnmatch.h.  It needs
> fnmatch-posix or fnmatch-gnu for that.

Yes, but it was not possible for the 'glob' module to specify one or the
other, because if the user wanted the other fnmatch module, it would collide.
This is now fixed.

> According to modules/glob: 
>   glob() function: Search for files and directories with paths matching a
>   pattern, with GNU extensions.
> This suggests that glob should depend on fnmatch-gnu.

The only GNU extension from fnmatch that glob uses is FNM_CASEFOLD, and only
for Amiga and VMS platforms. Porting efforts to these platforms are long
dead. I would suggest to remove this use of FNM_CASEFOLD, and let 'glob'
depend on 'fnmatch-posix' instead.

> But it also suggests the glob-module should be renamed to glob-gnu,
> following our usual naming pattern?

We use that naming pattern only when there is more than one module.
If we were to introduce a second 'glob' module that supports only POSIX [1],
then I would agree to rename the existing module. But if there's only
one choice, the renaming is gratuitous trouble for the gnulib users.


[1] http://www.opengroup.org/onlinepubs/9699919799/functions/glob.html

reply via email to

[Prev in Thread] Current Thread [Next in Thread]