[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests/test-strstr.c: Add another self-test.

From: Simon Josefsson
Subject: Re: [PATCH] tests/test-strstr.c: Add another self-test.
Date: Tue, 26 May 2009 14:48:18 +0200
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.94 (gnu/linux)

Eric Blake <address@hidden> writes:

> According to Simon Josefsson on 5/26/2009 6:15 AM:
>>    {
>> +    /* See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=521737 */
>> +    char *input = strdup ("aBaaaaaaaaaaax");
>> +    const char *result = strstr (input, "B1x");
> Does this mean we also need to beef up our strstr.m4 checks to catch
> platform bugs, instead of the current assumption that if you don't care
> about quadratic behavior, that the platform's strstr is always sufficient?

I'm not sure, it isn't clear that this particular strstr problem is a
common problem.

I think the first step is to add this to the self-test.  If we get
reports about it, we can try to learn which platforms and versions are
affected, and decide whether if it is worth to replace the system's
strstr where it fails in this way.  What do you think?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]