|
| From: | Eric Blake |
| Subject: | Re: [PATCH] tests/test-strstr.c: Add another self-test. |
| Date: | Tue, 26 May 2009 07:04:16 -0600 |
| User-agent: | Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.21) Gecko/20090302 Thunderbird/2.0.0.21 Mnenhy/0.7.6.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Simon Josefsson on 5/26/2009 6:15 AM:
> +2009-05-26 Simon Josefsson <address@hidden>
> +
> + * tests/test-strstr.c: Add another self-test.
> {
> + /* See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=521737 */
> + char *input = strdup ("aBaaaaaaaaaaax");
Did you take the proper precautions to ensure strdup is available? I'd
almost feel better if you rewrote this to use malloc/strcpy, rather than
dragging in dependencies just for the test.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkob6NAACgkQ84KuGfSFAYCvMACfVFg/NFXXr7yqbWG5sMJeTZ36
0agAnAsm3FV6KNPsja4i1aLrPYsZyIE6
=Bksd
-----END PGP SIGNATURE-----
| [Prev in Thread] | Current Thread | [Next in Thread] |