[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: another hash cleanup

From: Jim Meyering
Subject: Re: another hash cleanup
Date: Thu, 18 Jun 2009 22:10:58 +0200

Eric Blake wrote:

> Jim Meyering <jim <at> meyering.net> writes:
>> >    if (new_table == NULL)
>> >      return false;
>> > +  if (new_table->n_buckets == table->n_buckets)
>> > +    return true;
> Aargh.  Ten minutes after I push, I finally see my memory leak.
> Obviously, new_table needs to be freed before returning true.

Hah!  I should have looked at more than the patch.

Is that code path already exercised by test-hash.c?
If so, I would have seen it eventually, via valgrind.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]