[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: another hash cleanup

From: Jim Meyering
Subject: Re: another hash cleanup
Date: Fri, 19 Jun 2009 18:31:54 +0200

Jim Meyering wrote:
> Eric Blake wrote:
> ...
>> Done.  And with that on master, I've rebased my hash_rehash memory leak plug:
>> http://repo.or.cz/w/gnulib/ericb.git?a=shortlog;h=refs/heads/hash
>> $ git pull git://repo.or.cz/gnulib/ericb.git hash
> Thanks.  I've just started looking, and one thing struck me:
>     +static bool
>     +transfer_entries (Hash_table *src, Hash_table *dst, bool safe)
>     +{
> I'd prefer to make this like memcpy, strcpy, etc.
> which have the destination object on the left:
>     transfer_entries (Hash_table *dst, Hash_table *src, bool safe)

In testing, I pulled your change onto master and mistakenly pushed it
along with one of mine to test-hash.c.

Oh well.  I was going to say that modulo the comment above
it all looks fine.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]