[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: utimensat round 2
From: |
Eric Blake |
Subject: |
Re: utimensat round 2 |
Date: |
Fri, 09 Oct 2009 22:16:01 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Eric Blake on 10/8/2009 7:13 AM:
> Here's the current state of my utimensat series. It's now stable enough
> to post for review, although I reserve the right to rebase as I find
> tweaks are needed in the testsuite:
I've now implemented futimens. The tests pass on at least modern Linux,
pre-utimensat Linux, cygwin 1.5, cygwin 1.7, Solaris 10, darwin, FreeBSD,
OpenBSD; and cleanly compiles and skips on mingw. In the process, I found
a bug in cygwin 1.7 (utimensat improperly truncates) which now has a
pending patch, and in Linux (futimens(AT_FDCWD,NULL) attempts to change
the times of "." instead of failing).
I'm happy enough with the series that I will commit it tomorrow morning.
For now, here's where it can be reviewed, with differences from round 1:
git pull git://repo.or.cz/gnulib/ericb.git master
Eric Blake (8):
[1/8] doc: mention timestamp portability issues
More docs since my first email.
[2/8] utimens: add test
Test is more robust in the face of various timestamp issues.
[3/8] utimens: validate futimens usage
Now compiles on mingw.
[4/8] utimens: add lutimens interface
Don't make testsuite depend on nanosleep
[5/8] utimecmp: support symlink timestamps
Use pathconf(_PC_TIMESTAMP_RESOLUTION), if available.
[6/8] utimens: add UTIME_NOW and UTIME_OMIT support
Work around older Linux bug with UTIME_NOW and non-zero tv_sec.
[7/8] utimens: introduce fdutimens
Not much difference.
[8/8] futimens: new module
New. Write futimens for systems that lack it, and wrap it for systems
where it is broken. So far, only patched cygwin 1.7 passes using native
futimens.
>
> Still to go:
> implement utimensat
> implement fdutimensat
> work around Solaris bugs in trailing slash handling
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkrQCoEACgkQ84KuGfSFAYDhLgCfcKIqK4xWPMlR7h3fnO3jB40b
WZMAoKQwEH1WFsDI/TvRsWBWW6z6m4s2
=ziGP
-----END PGP SIGNATURE-----
- utimensat round 1, Eric Blake, 2009/10/08
- Re: utimensat round 2,
Eric Blake <=
- Re: utimensat round 2, Eric Blake, 2009/10/10
- Re: utimensat round 3, Eric Blake, 2009/10/15
- Re: utimensat round 3, Jim Meyering, 2009/10/16
- Re: utimensat round 3, Jim Meyering, 2009/10/16
- Re: utimensat round 3, Eric Blake, 2009/10/16
- Re: utimensat round 3, Jim Meyering, 2009/10/16
- Re: utimensat round 3, Eric Blake, 2009/10/16
- Re: utimensat round 3, Jim Meyering, 2009/10/16
- Re: utimensat round 4, Eric Blake, 2009/10/20
- Re: utimensat round 4, Jim Meyering, 2009/10/21