[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: enable -Werror for lib/ in coreutils
From: |
Eric Blake |
Subject: |
Re: enable -Werror for lib/ in coreutils |
Date: |
Tue, 27 Oct 2009 06:33:35 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Jim Meyering on 10/27/2009 6:24 AM:
> +
> + AC_SUBST([GNULIB_WARN_CFLAGS])
> + GNULIB_WARN_CFLAGS="$WARN_CFLAGS -Wno-missing-prototypes
> -Wno-uninitialized -Wno-unused-macros -Wno-old-style-definition"
Shouldn't this use gl_MANYWARN_COMPLEMENT([var], [$ws],
[-Wmissing-prototypes -Wuninitialized...]), rather than assuming that the
compiler will understand -Wno-missing-prototypes and friends?
> ++++ b/lib/isnan.c
> +@@ -67,6 +67,8 @@
> + ((sizeof (DOUBLE) + sizeof (unsigned int) - 1) / sizeof (unsigned int))
> + typedef union { DOUBLE value; unsigned int word[NWORDS]; } memory_double;
> +
> ++int FUNC (DOUBLE x);
Why are there no header files declaring rpl_isnan? Isn't a better fix to
patch math.in.h to declare everything that we will be providing?
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkrm6J8ACgkQ84KuGfSFAYAYBACdEYudpD2mVIEunvhDg7YfuVUF
JF0AnRMwgRbNBsVGfgpyHWAE+zSun/DA
=WFvv
-----END PGP SIGNATURE-----