Re: vasnprintf warnings

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Eric Blake on 10/30/2009 10:27 AM:
> Bruno, is it okay to apply this patch to silence these compiler warnings?
> 
> | vasnprintf.c:2378: warning: declaration of 'buf' shadows a previous local
> | vasnprintf.c:1502: warning: shadowed declaration is here
> 
> Here, using two different local variables buf with different types and nested 
> scopes is plain confusing.
> 
> | printf-args.c: In function printf_fetchargs:
> | printf-args.c:93: warning: signed and unsigned type in conditional 
> expression
> 
> Here, wint_t can be either signed or unsigned, so to be sure we aren't 
> causing 
> any problems with inadvertent sign extension, the extra cast seems the best 
> way 
> to go.
> 
> 
> From: Eric Blake <address@hidden>
> Date: Fri, 30 Oct 2009 10:24:45 -0600
> Subject: [PATCH] vasnprintf: avoid compiler warnings
> 
> * lib/vasnprintf.c (VASNPRINTF): Avoid shadowing our own local
> variables.
> * lib/printf-args.c (PRINTF_FETCHARGS): Avoid type mismatch.

Ping?

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkryL1UACgkQ84KuGfSFAYBgIQCfSZBEMUVMKhyeVZ5/yW0stAkz
79QAn09SLzOq34+7kBcowu769iQc21Fm
=cFtb
-----END PGP SIGNATURE-----