[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fix build warning in fnmatch_loop.c
From: |
Eric Blake |
Subject: |
Re: [PATCH] fix build warning in fnmatch_loop.c |
Date: |
Sun, 15 Nov 2009 07:42:58 -0700 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Robert Millan on 11/15/2009 3:46 AM:
>
> You don't want the assert() though? I figured it'd be useful for extra
> safety.
Safety from what? The code has been quite well-tested, belongs to a
static method, and both p and startp are local variables, so that you can
easily audit that all uses of NEW_PATTERN will comply. Adding an assert
will only slow it down.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAksAE3IACgkQ84KuGfSFAYBw6gCfcCxa1W76QWe2FC2yNb9PEucl
v/gAoLVqW4NzHotg28BruRwdap0Fyswe
=fetq
-----END PGP SIGNATURE-----
Re: [PATCH] fix build warning in fnmatch_loop.c, Robert Millan, 2009/11/09