Re: lib/regex_internal.h uses #if _LIBC instead of #if defined (_LIBC)

[Vladimir 'φ-coder/phcoder' Serbinenko]

Simon Josefsson wrote:
> "Vladimir 'φ-coder/phcoder' Serbinenko" <address@hidden> writes:
>
>   
>> === modified file 'gnulib/regex_internal.h'
>> --- gnulib/regex_internal.h    2009-12-27 15:37:18 +0000
>> +++ gnulib/regex_internal.h    2009-12-29 22:32:31 +0000
>> @@ -58,7 +58,7 @@
>>  # define SIZE_MAX ((size_t) -1)
>>  #endif
>>  
>> -#if (defined MB_CUR_MAX && HAVE_LOCALE_H && HAVE_WCTYPE_H &&
>> HAVE_ISWCTYPE && HAVE_WCSCOLL) || _LIBC
>> +#if (defined MB_CUR_MAX && HAVE_LOCALE_H && HAVE_WCTYPE_H &&
>> HAVE_ISWCTYPE && HAVE_WCSCOLL) || defined (_LIBC)
>>  # define RE_ENABLE_I18N
>>  #endif
>>     
>
> What is the real problem?  As far as I recall, undefined CPP symbols
> evaluate to 0.  So it is not an error to use _LIBC without first
> checking if it is defined.
>
>   
It's inconsistent with the rest of this file. Additionally it creates a
warning if -Wundef is defined which is a problem if project uses both
-Wundef and -Werror.
> /Simon
>
>   


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

signature.asc
Description: OpenPGP digital signature