[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: maintainer-makefile troubles and suggestions

From: Jim Meyering
Subject: Re: maintainer-makefile troubles and suggestions
Date: Thu, 21 Jan 2010 19:53:55 +0100

Martin von Gagern wrote:
> On 21.01.2010 17:10, Eric Blake wrote:
>> Thanks for all the feedback!
> I've got two more.
> sc_prohibit_atoi_atof:
> ----------------------
> The comment claims that [fs]?scanf doesn't provide error feedback. The
> "return value" section of my scanf(3) man page says differently: the
> number of successful conversions is returned, which is quite a suitable
> error indication in many cases, I believe.

Some implementations do not handle overflow.
If you do not want to use one of these tests,
add its name to the list in your project's cfg.mk file:

    # Tests not to run as part of "make distcheck".
    local-checks-to-skip = sc_prohibit_atoi_atof

> sc_prohibit_strcmp:
> -------------------
> Judging from the lib/streq.h file, STREQ seems to be only suitable for

That STREQ is unrelated to the definition that most of us use:

  #define STREQ(a, b) (strcmp (a, b) == 0)

As above, if you don't want it, add it to the list of checks to skip.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]