[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: arg-nonnull.h & warn-on-use.h in build-aux

From: Eric Blake
Subject: Re: arg-nonnull.h & warn-on-use.h in build-aux
Date: Tue, 23 Feb 2010 14:49:04 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20090812 Thunderbird/ Mnenhy/

According to Sam Steingold on 2/23/2010 2:05 PM:
> Hi,
> I updated gnulib in clisp and gnulib-tool installed arg-nonnull.h &
> warn-on-use.h in src/build-aux.
> why aren't these files in the usual place (src/gllib), together with all
> the other headers?

Because the versions in src/build-aux are templates, which get further
modified by a sed script during make, such that you end up using the
modified contents as the inline portion merged with *.in.h header
templates to form replacement headers in build/gllib.

> now, I am getting this error when building modules which use gnulib:
> make[2]: *** No rule to make target
> `CLISP-HOME/modules/syscalls/src/build-aux/arg-nonnull.h', needed by
> `arg-nonnull.h'.  Stop.

It seems like your problem is that top_srcdir is pointing to
CLISP-HOME/modules/syscalls/src instead of CLISP-HOME?  But why is that

> this is no good - I need to be able to specify the location of the
> build-aux directory (since it could be coming from an existing clisp
> installation, not a build directory).

I'm not sure I follow?  The build-aux directory is part of the source
tree, and does not get installed.  But you are correct that it is not part
of the build tree (unless you build in-tree, with srcdir==builddir).

> so, how do I specify the location of these files?
> this patch would help a lot:
> diff --git a/modules/warn-on-use b/modules/warn-on-use
> index f0ee83b..75346a7 100644
> --- a/modules/warn-on-use
> +++ b/modules/warn-on-use
> @@ -16,10 +16,10 @@ Makefile.am:
>  BUILT_SOURCES += warn-on-use.h
>  # The warn-on-use.h that gets inserted into generated .h files is the
> same as
>  # build-aux/warn-on-use.h, except that it has the copyright header cut
> off.
> -warn-on-use.h: $(top_srcdir)/build-aux/warn-on-use.h
> +warn-on-use.h: $(build_aux)/warn-on-use.h
>      $(AM_V_GEN)rm -f address@hidden $@ && \
>      sed -n -e '/^.ifndef/,$$p' \
> -      < $(top_srcdir)/build-aux/warn-on-use.h \
> +      < $(build_aux)/warn-on-use.h \
>        > address@hidden && \
>      mv address@hidden $@
>  MOSTLYCLEANFILES += warn-on-use.h warn-on-use.h-t
> (and a similar one for arg-nonnull)
> one would also need to somehow convince automake to add
> build_aux = $(top_srcdir)/build-aux

That just looks like a factorization - I'm not sure I see any difference




How is it supposed to help matters?

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]