[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: arg-nonnull.h & warn-on-use.h in build-aux

From: Eric Blake
Subject: Re: arg-nonnull.h & warn-on-use.h in build-aux
Date: Mon, 08 Mar 2010 12:16:11 -0700
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b1 Thunderbird/3.0.3

On 03/08/2010 11:34 AM, Sam Steingold wrote:
> Sam Steingold wrote:
>> Alternatively, I would be reasonably happy with
>> sed -i -e 's/_GL_ARG_NONNULL/GL_ARG_NONNULL/' arg-nonnull.h
>> sed -i -e 's/_GL_WARN_ON_USE/GL_WARN_ON_USE/' warn-on-use.h
>> similar to GL_LINK_WARNING in link-warning.h.
> So, any chance the constants in arg-nonnull.h & warn-on-use.h could be
> renamed to lose the leading underscore?
> note that the only other build-aux header, link-warning.h, defines
> macros _without_ the leading underscore, so it seems to make sense for
> the new headers in build-aux to lose the leading underscore too.

I'm still hoping Bruno will step in and help in this thread.
link-warning.h was created first, before we realized that the use of a
leading GL_ might lead to conflicts with other packages.  The use of a
leading _GL_ is intended to mark items that are specifically in gnulib's

As to whether the template files live in build-aux or get moved to lib,
Bruno needs to answer why link-warning.h was originally stuck in
build-aux rather than lib.  For arg-nonnull and warn-on-use, they are
just following precedent.  If we do any motion, all three files should
be handled the same way.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]